[Applab][Libraries] Catch openuri too long error and show message #39057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -165,7 +166,14 @@ export default class LibraryPublisher extends React.Component { | |||
| libraryJson, | |||
| error => { | |||
| console.warn(`Error publishing library: ${error}`); | |||
| this.setState({publishState: PublishState.ERROR_PUBLISH}); | |||
| if ( | |||
| error.message === | |||
There was a problem hiding this comment.
what does this error object look like? could we match on a status code or something instead of matching the message string?
There was a problem hiding this comment.
Yeah, I thought about that too but it's not clear to me how to do this more cleanly. This is was we have at this point:
It comes from here
please let me know if you know a better way to do this!
There was a problem hiding this comment.
oh, right, i've run into this same thing before. i don't think there's a better way to handle this right now 😢 i added a tech debt ticket for us to discuss: https://codedotorg.atlassian.net/browse/STAR-1441
maddiedierker
approved these changes
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've gotten several reports in Zendesk about libraries failing to publish.
It looks like at least some of these issues are caused by the library being too long for the profanity checker. This results in and
OpenURI::HTTPError(which also results in a honeybadger error)We need to rethink how the profanity checking happens a little more broadly (see slack thread and jira ticket), but for now, we can just surface a better error for the user.
Links
Testing story
Reviewer Checklist: