Add LevelDetailsDialog and implement three level types #39087
Conversation
bethanyaconnor
requested review from
dmcavoy,
Hamms and
a team
and removed request for
dmcavoy and
Hamms
| handleClose: PropTypes.func.isRequired | ||
| }; | ||
|
|
||
| getContentComponent = level => { |
There was a problem hiding this comment.
Nice progress! I noticed that the "popover" in the spec shows the workspace header (insructions, help & tips, etc). Not sure if this is just future work, but seeing it would really help me place that the content shown here is the instructions of the level (if that is in fact what it is).
| expect(loadVideoSpy.calledOnce).to.be.true; | ||
| expect(wrapper.contains('Some things to think about.')).to.be.true; | ||
| }); | ||
| }); |
|
@davidsbailey Most levels will have the instructions in the popover but it's been proving a bit tricky so I thought it would be easier to get some of the simpler code in earlier. Here's a work in progress shot of what it will likely look like when everything is done! |
Its probably also worth pointing out that all the level types in this PR do not use a the instructions area currently on the levels themselves |
|
Thanks @bethanyaconnor and @dmcavoy , all makes sense! |
In an effort to avoid a 600+ line PR, I realized I could break the LevelDetails work into multiple PRs using Storybook. This means that this PR doesn't connect this dialog to the lesson plans.
This PR implements three level types:
StandaloneVideo:
External:
LevelGroup (text adapted from CurriculumBuilder):
Links
Testing story
This PR is all testing 馃槄 . Added both Storybook and unit tests.
PR Checklist: