Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear certain CDO.shared_cache cache keys between every test #39108

Merged
merged 8 commits into from Feb 24, 2021

Conversation

maddiedierker
Copy link
Contributor

@maddiedierker maddiedierker commented Feb 17, 2021

Partially reimplements #39047, which was reverted in #39072 because clearing CDO.shared_cache between tests causes OmniauthCallbacksController tests to fail (FND-1411).

I will run this build on Drone multiple times to hopefully uncover any possible flakiness introduced by this change before merging.

@maddiedierker maddiedierker requested review from a team, daynew and hacodeorg February 19, 2021 17:41
Copy link
Contributor

@hacodeorg hacodeorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for doing this.

@maddiedierker maddiedierker merged commit 5c715d6 into staging Feb 24, 2021
@maddiedierker maddiedierker deleted the revert-39072-revert-39047-clear-cache-tests branch February 24, 2021 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants