[AiLab] protect against errors in metadata retrieval #39133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erin007
changed the title
davidsbailey
approved these changes
Feb 18, 2021
breville
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HoneyBadger Error 1
HoneyBadger Error 2
There were a few scenarios where
api/v1/ml_models/metadata/:model_idcould cause an errors.If no model was found => NoMethodError undefined method 'metadata' for NilClass
If a model was found, but didn't have metadata => no implicit conversion of nil into String when we try to parse
I added safe operators and a check that metadata != nil to prevent these errors from happening.