[AiLab] fix layout and id bugs in autogenerated continuous feature input fields #39134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for a couple of problems in autogenerated code and design elements for continuous features:
1.) The
getTextcode for continuous features was referencing "undefined" rather than the correct element id. To fix I assigned the element id to a variable and correctly passed that variable to the code that generatesgetText.2.) The generated input boxes were all stacked in the top left corner rather than aligned correctly in the layout of the screen. To fix, I needed to pass x and y coordinates to the
createElementfunction for those input fields.BEFORE:
AFTER:
