Javalab: Use codemirror #39147
Merged
Javalab: Use codemirror #39147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmkulwik
reviewed
Feb 19, 2021
| dispatchEditorChange = () => { | ||
| return tr => { | ||
| // we are overwriting the default dispatch method for codemirror, | ||
| // so we need to manually call the update method. |
There was a problem hiding this comment.
This commenting is very helpful :)
jmkulwik
reviewed
Feb 19, 2021
| } | ||
|
|
||
| dispatchEditorChange = () => { | ||
| return tr => { |
There was a problem hiding this comment.
tr is a codemirror transaction I'll add a comment to make it more clear
|
Haha I'm glad I'm in an empty room, because I might have otherwise startled anyone nearby. So excited about this change!!! |
jmkulwik
reviewed
Feb 22, 2021
| @@ -0,0 +1,52 @@ | |||
| import { | |||
There was a problem hiding this comment.
This separation of concerns will make maintenance easy and straightforward 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using Ace as our editor in Javalab, switch to Codemirror version 6
Our main reason for the switch is codemirror 6 has been redesigned with accessibility in mind and has things such as tab navigation built in. Ace does not have a solution for tab navigation (you get stuck in the ace editor with no way out beyond us doing something hacky).
Note that this is a different version of codemirror than we use elsewhere because we want to take advantage of the new accessibility features. However the new codemirror has different package names than the old one so it should not be an issue.
We still allow tabbing in the editor, but the user can continue navigation by doing
esc+tab.The new editor looks like this:
Links
Testing story
Tested locally. Verified we are still writing updates to redux so we can save/run code later (we do not have that functionality yet).
PR Checklist: