New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added CSA to course explorer table #39150
Conversation
…urses_show_csa" flag
@@ -53,8 +82,8 @@ | |||
starts: 9, | |||
ends: 12, | |||
range: "Grades 9-12", | |||
regular_order: 0, | |||
responsive_small_order: 2, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we also updated the ordering of courses in the responsive view, which is why some of these values have been updated.
@@ -216,9 +245,10 @@ | |||
.arrow | |||
%i.arrow-down{class: "fa fa-caret-down"} | |||
%i.arrow-up{class: "fa fa-caret-up"} | |||
- if course[:range] | |||
- if course[:range] || course[:announcement] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be course[:range] && course[:announcement]
? Are both being displayed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since the previous logic was if course[:range]
i wanted to allow for the possibility that there is no course range (even though all our courses have ranges). we need the %br/
if either value is present, but we display them next to each other and if one is absent it renders nothing. so this should read: "if we have a range or an announcement, add a <br>
, then try to render both".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i realize this code didn't make much sense without a screenshot of the responsive view! which i just added to the description.
this adds a "CSA - coming 2022" row to our course explorer table, rendered conditionally based on a DCDO "courses_show_csa" flag.