Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added CSA to course explorer table #39150

Merged
merged 1 commit into from Feb 19, 2021

Conversation

cforkish
Copy link
Contributor

@cforkish cforkish commented Feb 19, 2021

this adds a "CSA - coming 2022" row to our course explorer table, rendered conditionally based on a DCDO "courses_show_csa" flag.

Screen Shot 2021-02-18 at 5 39 54 PM

Screen Shot 2021-02-18 at 4 26 04 PM

@@ -53,8 +82,8 @@
starts: 9,
ends: 12,
range: "Grades 9-12",
regular_order: 0,
responsive_small_order: 2,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we also updated the ordering of courses in the responsive view, which is why some of these values have been updated.

@@ -216,9 +245,10 @@
.arrow
%i.arrow-down{class: "fa fa-caret-down"}
%i.arrow-up{class: "fa fa-caret-up"}
- if course[:range]
- if course[:range] || course[:announcement]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be course[:range] && course[:announcement]? Are both being displayed here?

Copy link
Contributor Author

@cforkish cforkish Feb 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since the previous logic was if course[:range] i wanted to allow for the possibility that there is no course range (even though all our courses have ranges). we need the %br/ if either value is present, but we display them next to each other and if one is absent it renders nothing. so this should read: "if we have a range or an announcement, add a <br>, then try to render both".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i realize this code didn't make much sense without a screenshot of the responsive view! which i just added to the description.

@cforkish cforkish merged commit f0858c2 into staging Feb 19, 2021
@cforkish cforkish deleted the cforkish/LP-1739-add-csa-upsell-banner branch February 19, 2021 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants