New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Javalab: switch query in render_app_dependencies #39187

Merged

molly-moen merged 1 commit into staging from java-lab-fix

Feb 23, 2021

Contributor

molly-moen commented Feb 23, 2021

Doing a @level.game == Game.javalab query is causing cache test failures. Switch to is_a?(Javalab) to avoid querying unnecessarily.

PR Checklist:

Tests provide adequate coverage
Privacy and Security impacts have been assessed
Code is well-commented
New features are translatable or updates will not break translations
Relevant documentation has been added or updated
User impact is well-understood and desirable
Pull Request is labeled appropriately
Follow-up work items (including potential tech debt) are tracked and linked


          switch to is_a?

19665aa

molly-moen requested a review from jmkulwik

February 23, 2021 01:55

jmkulwik approved these changes

View reviewed changes

Contributor

jmkulwik left a comment

👍

molly-moen merged commit 2aea2f7 into staging

molly-moen deleted the java-lab-fix branch

February 23, 2021 01:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment