-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Button to Student Facing Lesson Plans on Script Overview Page #39202
Conversation
…tudent-lesson-plan-part-3
…code-dot-org into student-lesson-plan-part-3
…code-dot-org into student-lesson-plan-part-3
…code-dot-org into student-lesson-plan-part-3
This is looking really nice Jillian! I slacked you a question about what we want to happen when a lesson is lockable and has a lesson plan. Is the button still clickable? Also don't forget to pull in the UI test from the earlier PR and update it to add in click these buttons. |
…code-dot-org into student-lesson-plan-part-3
Oh I think the button was still clickable, I just added disabling the button if the lesson is locked. |
Can you still navigate to the student lesson plan from other student lesson plans using the dropdown or directly through the URL |
I think so :( This is probably an ability.rb change right. |
…code-dot-org into student-lesson-plan-part-3
I think its a change to the controller, we might not need to do it in ability.rb. I think we don't need to block this PR on this issue. I can take a follow up task here to figure out how we want to lock this down. https://codedotorg.atlassian.net/browse/PLAT-792 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR is ready for team review once you pull in the UI test from the previous PR and update to add the clicking of the button. Let me know if you want me to make those updates.
…code-dot-org into student-lesson-plan-part-3
dashboard/test/ui/features/learning_platform/student_lesson_plan.feature
Outdated
Show resolved
Hide resolved
…tudent-lesson-plan-part-3
This adds buttons to the student facing lesson plan on the script overview page for lessons that have a lesson plan and scripts that have include_student_lesson_plans set to true.
This is what the script overview page looks like for students
For teachers:
Links
PR Checklist: