Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed obsolete section progress table code. #39204

Merged
merged 1 commit into from Feb 24, 2021
Merged

removed obsolete section progress table code. #39204

merged 1 commit into from Feb 24, 2021

Conversation

cforkish
Copy link
Contributor

this PR removes all the code from the old progress table implementation that is no longer used.

@cforkish cforkish requested review from a team and jamescodeorg February 24, 2021 00:11
jamescodeorg
jamescodeorg approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@jamescodeorg jamescodeorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a previous job, we used to call these "all ketchup" reviews. (I supposed that made more sense when added lines were highlighted in yellow instead of green.) At any rate, these are my favorite kind of reviews! :-)

@cforkish
Copy link
Contributor Author

"all ketchup" -- love it!

@cforkish cforkish merged commit 48f97dc into staging Feb 24, 2021
@cforkish cforkish deleted the cforkish/LP-1744-cleanup-obsolete-table-code branch February 24, 2021 22:39
@cforkish cforkish added the student progress PRs related to student progress label Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamescodeorg jamescodeorg jamescodeorg approved these changes

Assignees
No one assigned
Labels
student progress PRs related to student progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cforkish @jamescodeorg