Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare to start using new standards field in existing standards report #39330

Merged
merged 3 commits into from
Mar 7, 2021

Conversation

davidsbailey
Copy link
Member

@davidsbailey davidsbailey commented Mar 4, 2021

Continues work on PLAT-750. This PR does a few "pre flight" steps in preparation for switching the existing standards report over to using the new parts of the data model. specifically:

  1. Adds a tiny bit of test coverage to the existing ui tests for the standards report. This will help make sure that we do not mess up when switching to pulling the standards shortcodes from the new database column.

  2. starts using new standards fields when importing lesson-standard relationships from CB

  3. starts sending new fields down to the client.

For more background, see Lesson Standards design doc.

Test Coverage

  • The UI test touched in this PR covers (1) importing lesson-standard relationships, (2) the Standards tab, (3) the standards report which can be generated from that tab. I also tested all 3 of these manually.
  • JS unit tests provide good coverage for the standards tab

And element "#uitest-progress-standards-table" contains text "1A-AP-08"
And element "#uitest-progress-standards-table" contains text "Model daily processes by creating and following algorithms (sets of step-by-step instructions) to complete tasks."
And element "#uitest-progress-standards-table" contains text "Available in 1 Lesson:"
And element "#test-how-to-standards" contains text "How to use this information"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these elements should already have been rendered by this point, so we do not need to perform an additional wait.

@davidsbailey davidsbailey changed the title add standard shortcode to existing ui test prepare to start using new standards field in existing standards report Mar 4, 2021
Copy link
Contributor

@dmcavoy dmcavoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidsbailey davidsbailey merged commit 8278b8c into staging Mar 7, 2021
@davidsbailey davidsbailey deleted the standards-report-uitest branch March 7, 2021 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants