refactor the TextareaWithImageUpload component to instead be MarkdownEnabledTextarea
#39333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ownEnabledTextarea` A component which can programmatically add a number of different kind of features like ImageUpload
8 tasks
davidsbailey
reviewed
Mar 5, 2021
| </div> | ||
| ); | ||
| } | ||
| } |
There was a problem hiding this comment.
Sorry for the late request, but would you be willing to do some git-fu like git mv TextareaWithImageUpload.jsx MarkdownEnabledTextarea.jsx to preserve revision history and make diffs easier to see, now and in the future? (here and below for test file) Open to reasons we might not want to do this, but would prefer this pattern if there is no reason not to.
There was a problem hiding this comment.
That's already the state of the current revision history. There were just enough edits made to the files after moving them that they show up as different files in the overall diff, but if you examine the diff for the first commit individually you'll see what you're looking for
davidsbailey
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A component which can programmatically add a number of different kind of features like ImageUpload. Also expand it to support Resource Links in addition to image uploads.
Testing story
Added a unit test, updated existing.
PR Checklist: