Improvements to editing expandable images #39336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmcavoy
changed the title
dmcavoy
changed the title
Hamms
approved these changes
Mar 4, 2021
Comment on lines
50
to
51
| let param = expandable ? 'expandable' : ''; | ||
| let e = {target: {value: this.props.markdown + `\n\n`}}; |
There was a problem hiding this comment.
nit:
Suggested change
| let param = expandable ? 'expandable' : ''; | |
| let e = {target: {value: this.props.markdown + `\n\n`}}; | |
| const param = expandable ? 'expandable' : ''; | |
| const e = {target: {value: this.props.markdown + `\n\n`}}; |
| type="checkbox" | ||
| checked={this.state.expandable} | ||
| style={styles.checkbox} | ||
| onChange={() => this.setState({expandable: !this.state.expandable})} |
There was a problem hiding this comment.
I believe this should be something like
Suggested change
| onChange={() => this.setState({expandable: !this.state.expandable})} | |
| onChange={(e) => this.setState({expandable: e.target.checked})} |
|
|
||
| ReactDOM.render( | ||
| <Provider store={getStore()}> | ||
| <ExpandableImageDialog /> |
There was a problem hiding this comment.
is there a specific reason this can't just go in edit-container alongside LessonEditor above?
| <SafeMarkdown markdown={lesson.preparation} /> | ||
| <EnhancedSafeMarkdown | ||
| markdown={lesson.preparation} | ||
| expandableImages={true} |
There was a problem hiding this comment.
I think you can just do
Suggested change
| expandableImages={true} | |
| expandableImages |
here and elsewhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a checkbox which allows an editor to say if an image is expandable so that editors don't have to memorize the syntax for expandable images in order to add an expandable image. It adds the syntax for them.
Makes expandable images work in the lesson editor so you can preview them there.
Testing story
Follow-up work
Do we want to make expandable images work for the ScriptOverview or CourseOverview?
PR Checklist: