Removing three deprecated pilots #39356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cleanup PR for the pilot experiment page. We are building out documentation for how this will be managed in the future here: https://docs.google.com/document/d/1tokG6iZ2bhvsaGw4MUF2rXbPCRsBdv1hVeew8yiHRUo/edit
These three pilots have already ended, so this is simply to pull them from the admin pilot page. Several of the tests used the CSD pilot, so those have been updated to use the CSP pilot.
Testing: Locally, I created a section and assigned a pilot course. Upon deleting that script, the course disappeared, and I was no longer able to log in as a student from that course or create a new section based on the same pilot. So, the access for teachers is actually dependent on the availability of the script, and not its existence on experiment.rb. The scripts for these three pilots have already been removed, so this update will just affect their display on the admin page.
Future work: Create a feature where any admin user can remove a teacher from a pilot (hook up disable_single_user_experiment to a UI tool) so that we are cleaning out our databases entirely. Currently, these databases still contain information from these deprecated pilots, which this PR does not address.