No longer notify Honeybadger when throttling requests #39360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of #38143 and #38148, we notify Honeybadger every time a user is throttled by
POST /profanity/find(Honeybadger) orPOST /dashboardapi/v1/text_to_speech/azure(Honeybadger). This was for monitoring purposes to make sure we aren't improperly throttling users. Since those PRs have merged, I've investigated high-volume occurrences of this error to make sure everything looks okay (e.g., the user wasn't throttled for too long and we aren't seeing huge influxes of throttling based on user IP).To date, all of the throttling occurrences have been expected, so I'm removing the logging as it's noisy. Users see a message that they've been throttled when this happens, so they can also reach out to support if they think they've been unnecessarily throttled.
Links
POST /profanity/findHoneybadgerPOST /dashboardapi/v1/text_to_speech/azureHoneybadgerTesting story
Updated appropriate test.