Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Java Lab to allthethings and integrated continue button #39364

Merged
merged 1 commit into from
Mar 6, 2021

Conversation

jmkulwik
Copy link
Contributor

@jmkulwik jmkulwik commented Mar 5, 2021

Added a continue button. (The stop button is also new. It's non-functional right now, but will be in the final UX).
Also added a new lesson and two new levels to the allthethings script.
studio.code.org/s/allthethings/stage/44/puzzle/1
studio.code.org/s/allthethings/stage/44/puzzle/2

The continue button marks the lesson green and moves to the next level.

image

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@jmkulwik jmkulwik requested a review from a team as a code owner March 5, 2021 18:56
@jmkulwik jmkulwik requested a review from molly-moen March 5, 2021 18:56
@@ -10,7 +10,7 @@ import {EditorState} from '@codemirror/state';
const style = {
editor: {
width: '100%',
height: 600,
height: 400,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only changed this so everything would fit on my small laptop screen. Happy to change it back.

@jmkulwik jmkulwik requested a review from a team March 5, 2021 18:57
@@ -5495,7 +5559,7 @@
},
{
"seeding_key": {
"level.key": "2-3 Maze 6",
"level.key": "2-3 Maze 3",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@code-dot-org/curriculum-platform - I added you to the review because of these changes. Not sure what's going on here. I didn't change this, but I'm guessing it was updated when I saved the allthethings script. Does it look ok?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(also there are a few below and above that are similar)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes to this file look good! right now we generate changes to this file in preparation for moving to actually using this format, but currently this file is not used for anything. .script_json files are only used is_migrated scripts, which are currently just those in CSF / CSD / CSP 2021.

@@ -5495,7 +5559,7 @@
},
{
"seeding_key": {
"level.key": "2-3 Maze 6",
"level.key": "2-3 Maze 3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes to this file look good! right now we generate changes to this file in preparation for moving to actually using this format, but currently this file is not used for anything. .script_json files are only used is_migrated scripts, which are currently just those in CSF / CSD / CSP 2021.

Copy link
Contributor

@molly-moen molly-moen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jmkulwik jmkulwik merged commit 977f2b5 into staging Mar 6, 2021
@jmkulwik jmkulwik deleted the csa-run-button-integration branch March 6, 2021 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants