-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Java Lab to allthethings and integrated continue button #39364
Conversation
@@ -10,7 +10,7 @@ import {EditorState} from '@codemirror/state'; | |||
const style = { | |||
editor: { | |||
width: '100%', | |||
height: 600, | |||
height: 400, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only changed this so everything would fit on my small laptop screen. Happy to change it back.
@@ -5495,7 +5559,7 @@ | |||
}, | |||
{ | |||
"seeding_key": { | |||
"level.key": "2-3 Maze 6", | |||
"level.key": "2-3 Maze 3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@code-dot-org/curriculum-platform - I added you to the review because of these changes. Not sure what's going on here. I didn't change this, but I'm guessing it was updated when I saved the allthethings script. Does it look ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(also there are a few below and above that are similar)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes to this file look good! right now we generate changes to this file in preparation for moving to actually using this format, but currently this file is not used for anything. .script_json files are only used is_migrated
scripts, which are currently just those in CSF / CSD / CSP 2021.
@@ -5495,7 +5559,7 @@ | |||
}, | |||
{ | |||
"seeding_key": { | |||
"level.key": "2-3 Maze 6", | |||
"level.key": "2-3 Maze 3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes to this file look good! right now we generate changes to this file in preparation for moving to actually using this format, but currently this file is not used for anything. .script_json files are only used is_migrated
scripts, which are currently just those in CSF / CSD / CSP 2021.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Added a continue button. (The stop button is also new. It's non-functional right now, but will be in the final UX).
Also added a new lesson and two new levels to the allthethings script.
studio.code.org/s/allthethings/stage/44/puzzle/1
studio.code.org/s/allthethings/stage/44/puzzle/2
The continue button marks the lesson green and moves to the next level.
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: