[AiLab] Delete controller method, route and tests for ML models #39844
Conversation
| return head :forbidden unless @user_ml_model.user_id == current_user.id | ||
| @user_ml_model.destroy | ||
| delete_from_s3(@user_ml_model.model_id) | ||
| end |
There was a problem hiding this comment.
Do we need to specify anything about what we return as content here? dont_cache, no_content, etc.?
| def delete_from_s3(model_id) | ||
| AWS::S3.delete_from_bucket(S3_BUCKET, model_id) | ||
| end |
There was a problem hiding this comment.
Great work! This is new to me. Would we ever need to verify/test that this action is successful in S3?
There was a problem hiding this comment.
This delete method will return a boolean indicating whether the deletion worked or not. I took your idea and use it in the check above. Thanks!
| get 'ml_models/names', to: 'ml_models#user_ml_model_names' | ||
| get 'ml_models/:model_id', to: 'ml_models#get_trained_model' | ||
| get 'ml_models/:model_id/metadata', to: 'ml_models#user_ml_model_metadata' | ||
| resources :ml_models, only: [:show, :destroy] do |
There was a problem hiding this comment.
@madelynkasula You suggested I use resource for the ml_models routes on an older PR - just now getting to it. Is this what you were thinking?
There was a problem hiding this comment.
yes, this is exactly what i was thinking! thank you for following up on that
| render json: {id: @user_ml_model.id, status: status} | ||
| head :no_content |
There was a problem hiding this comment.
These appear to conflict with other, but so long as #39924 takes care of it, then I guess that's okay.
Setting up the controller action and route to delete trained models from the UserMlModel table and S3, including a couple of tests.