Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for time spent pilot #39873

Merged
merged 5 commits into from
Apr 8, 2021
Merged

Conversation

cforkish
Copy link
Contributor

@cforkish cforkish commented Apr 2, 2021

this includes a few fixes to the functionality for the time spent pilot

  1. main issue: we were parsing timestamp values of seconds as milliseconds, resulting in the wrong displayed date
  2. modifying a section in the "manage students" tab was resetting our section progress redux, so we were losing the flag for the pilot
  3. expanding rows PR regressed table header border widths
  4. update to round time spent values up instead of down, to avoid lots of 0's

Links

@@ -33,7 +33,7 @@ const styles = {
}
};

class ManageStudentActionsCell extends Component {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is unrelated to the PR task, but included as a general QOL improvement. when i went to track the redux flow that was resetting our pilot flag, i had trouble finding usages of this component due to a typo in its name.

@cforkish cforkish requested a review from a team April 2, 2021 21:27
@cforkish cforkish force-pushed the cforkish/LP-1845-time-spent-updates branch from 967ea43 to e403806 Compare April 8, 2021 18:34
@cforkish cforkish merged commit e79d0b6 into staging Apr 8, 2021
@cforkish cforkish deleted the cforkish/LP-1845-time-spent-updates branch April 8, 2021 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants