Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Temporarily disable the import_google_sheets job" #39933

Merged

Conversation

maureensturgeon
Copy link
Contributor

@maureensturgeon maureensturgeon commented Apr 6, 2021

Reverts #39872

Thread here for reference: https://codedotorg.slack.com/archives/C0T0PNTM3/p1617309794310400. It was discovered that the v3 folder was not in the pegasus directory what was there was a v3 shortcut which pointed to the folder (this must have happened when the permissions of the files were changed from Anthony's account to site.googlecloud).

On staging, the issue with the gsheet sync could be reproduced by querying for a sheet, for example cdo_donors with @session.file_by_title(['Pegasus', 'v3', 'cdo-donors']), which returned nil. We decided to move the real v3 folder from the top-level "My Drive" folder to the Pegasus folder. After making this change, querying @session.file_by_title(['Pegasus', 'v3', 'cdo-donors']) returned the expected file on staging.

To further verify the change, in staging/pegasus I ran rake PEGASUS_RAKE_LOGGER=true seed:sync i18n:sync 2>&1 and saw the results here https://codedotorg.slack.com/archives/C03CK8E51/p1617743090260000.

@maureensturgeon maureensturgeon marked this pull request as ready for review April 6, 2021 21:23
Copy link
Contributor

@sureshc sureshc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

Copy link
Contributor

@hacodeorg hacodeorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Maureen!

@maureensturgeon maureensturgeon merged commit 39e80e9 into staging Apr 8, 2021
@maureensturgeon maureensturgeon deleted the revert-39872-ha/disable-import-google-sheets branch April 8, 2021 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants