Set user_return_to in GET /maker/google_oauth_confirm_login #39949
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug came up while investigating a different ticket -- STAR-1496 (using Google OAuth from the Maker App fails for users with unmigrated accounts).
Local repro steps (these don't repro on production because the bug hadn't been released yet):
Expected: the browser redirects to /maker/display_google_oauth_code with the “magic code” to copy-paste back into the Maker App
Actual: the browser redirects to /home
This was happening because in browser/#76, we changed the "Login with Google" route in the Maker App:
GET /users/sign_in?user_return_to=/maker/display_google_oauth_code
GET /maker/google_oauth_confirm_login?user_return_to=/maker/display_google_oauth_code
This change was intentional, but broke the
user_return_to
feature because the old route setsession[:user_return_to]
, but the new route didn't. Now,session[:user_return_to]
will be set in the new route.Testing story
Added an integration test for this scenario.