Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update search routes for programming expressions, vocab and resources #39950

Merged
merged 3 commits into from
Apr 7, 2021

Conversation

dmcavoy
Copy link
Contributor

@dmcavoy dmcavoy commented Apr 7, 2021

I really liked the way Dave set up the route for searching for standards so I thought it would be good to move everything over to the same set up. It had the added benefit of it makes the routes file cleaner :)

Testing story

There are existing tests for these routes. I also went to the lesson edit page and tried each one manually.

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

Copy link
Contributor

@bethanyaconnor bethanyaconnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

Copy link
Member

@davidsbailey davidsbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks for doing this! definitely easier to make this kind of change before launch than after :-)

@dmcavoy dmcavoy merged commit 1bbe834 into staging Apr 7, 2021
@dmcavoy dmcavoy deleted the update-search-routes branch April 7, 2021 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants