Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort standards on lesson edit page #39955

Merged
merged 4 commits into from
Apr 8, 2021
Merged

Conversation

davidsbailey
Copy link
Member

@davidsbailey davidsbailey commented Apr 7, 2021

Finishes PLAT-897. While it is possible to make reactabular sort the data for us, it seemed easier to do it in the redux action. If we ever want the user to be able to change how the data is sorted, we can switch to using reactabular to sort the data instead.

sorts by framework name and then by standard shortcode. for consistency, also add sorting on the backend, since it turns out we were relying on the database ordering there.

before

Screen.Recording.2021-04-07.at.12.57.11.PM.mov

after

Screen.Recording.2021-04-07.at.1.12.51.PM.mov

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@davidsbailey davidsbailey changed the title Sort standards edit Sort standards on lesson edit page Apr 7, 2021
@davidsbailey davidsbailey requested review from a team and removed request for a team April 7, 2021 20:15
@davidsbailey davidsbailey merged commit 097471f into staging Apr 8, 2021
@davidsbailey davidsbailey deleted the sort-standards-edit branch April 8, 2021 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants