Revert "Revert "Update all instances of [slide] placeholder syntax""
#39960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oooooh, I figured it out. For some reason, I had it in my head that Now I understand that I should have tested this with |
|
Seed:courses just seeds the courses. Seed scripts seeds scripts, lesson groups, lessons |
dmcavoy
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #39959, restoring #39834
The original PR introduced a bunch of JSON errors because I completely forgot to escape the
"in the new syntax. I thought I had tested that by re-seeding locally, but apparently that didn't work since obviously it didn't catch the error. In addition to correctly escaping that syntax in this PR, I'm also going to attempt to figure out why my tests didn't work.