Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix teacher application export via smaller batch size for Google Sheet uploads #39977

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

bencodeorg
Copy link
Contributor

@bencodeorg bencodeorg commented Apr 8, 2021

Our export of teacher application data to Google Sheets is failing due to a connection timeout (ie, the upload into the gsheet takes too long). We faced this issue last year, and introduced batching to resolve it. This PR reduces the batch size even further.

Testing story

Using some instructions here, I created 4000 dummy applications locally. I was able to reproduce the error before changing the batch size. Then, I successfully uploaded those applications to a test gsheet in a little over 20 minutes.

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@bencodeorg bencodeorg requested a review from a team April 8, 2021 16:29
@bencodeorg bencodeorg changed the title Smaller batch size for Google Sheet uploads Smaller batch size for Google Sheet uploads (fix teacher application export) Apr 8, 2021
@bencodeorg bencodeorg changed the title Smaller batch size for Google Sheet uploads (fix teacher application export) Fix teacher application export via smaller batch size for Google Sheet uploads Apr 8, 2021
@bencodeorg bencodeorg merged commit ea0dc1d into staging Apr 8, 2021
@bencodeorg bencodeorg deleted the teacher-application-gsheet-export-bug-fix branch April 8, 2021 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants