Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update all remaining code blocks to use new programming expression syntax #39983

Merged
merged 1 commit into from Apr 8, 2021

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Apr 8, 2021

Pass 2: The Rest

Follow-up to #39839

Looks like we actually got nearly everything in the "easy stuff" pass! All that was left were a handful of console.log expressions in CSP Unit 7, which I manually updated.

All remaining instances of inline code syntax in lesson plans appear to be just plaintext code examples and - much more commonly - text occurring in between code examples, as you expect to see when using a basic regex to match something like `*`

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@Hamms Hamms requested a review from a team April 8, 2021 19:59
@Hamms Hamms merged commit 57c39e1 into staging Apr 8, 2021
@Hamms Hamms deleted the update-final-code-blocks branch April 8, 2021 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants