Don't convert file data to string when saving project files #40006
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where images weren't being saved correctly from curriculum starter image files because the image data was converted to a string before saving, causing us to save corrupted image data.
Repro steps (as of the time of writing, this will consistently repro on production):
/s/csd2-2020/stage/9/puzzle/6
)Expected: My change was saved, and all assets render properly.
Actual: My change was saved, but image assets do not render properly (render as broken image links).
Users that have encountered this situation will need to reset version history to get back to a good state.
Links
Testing story
This issue wasn't caught by unit tests since we have to mock this data. I've created a ticket as follow-up work to cover this scenario with a UI test (likely an Eyes test).
Follow-up work