[AiLab] pending delete spinner and show model list without freshly deleted model #40064
Conversation
|
Just out of curiosity: in the video, the initial dataset doesn't have a delete button. Is that expected? |
| }); | ||
| } else { | ||
| this.setState({confirmDialogOpen: false}); | ||
| this.setState({confirmDialogOpen: false, isDeletePending: false}); | ||
| this.getModelList(); |
There was a problem hiding this comment.
Should we show a spinner while isModelListPending is true as well? (If not, should we keep isDeletePendingastrue` until the model list reload completes?
(In theory we could avoid a fresh retrieval of models by just adjusting our local list, but I actually like the idea here of getting a fresh set of information.)
|
Yes, that’s expected. In this case it’s a model trained by a level builder
that we don’t want to be deletable by a student.
On Wed, Apr 14, 2021 at 12:20 AM Brendan Reville ***@***.***> wrote:
Just out of curiosity: in the video, the initial dataset doesn't have a
delete button. Is that expected?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#40064 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC53C7LUSCGJKM2NXDILT5LTIUJYHANCNFSM424LKTUA>
.
--
Erin Bond
Software Engineer
Code.org
|
|
After going through the levels, I think we should also show a spinner rather than an empty dropdown when loading the model list when we first see this dialog. |
https://trello.com/c/LxDYLahQ/177-show-a-spinner-rather-than-an-empty-dropdown-when-loading-the-model-list-in-the-model-manager tracking as follow up |
Follow up to address #39924 (comment)
Screen.Recording.2021-04-13.at.8.45.43.PM.mov