Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record lesson id when announcement is clicked on lesson plan #40079

Merged
merged 5 commits into from Apr 20, 2021

Conversation

dmcavoy
Copy link
Contributor

@dmcavoy dmcavoy commented Apr 14, 2021

Updates existing firehose for announcement clicks to include lesson id if on a lesson.

study: "notification_engagement"
event: "notification_click"
lesson_id included
uuid included
data_json: includes lesson_id, notice, details, buttonLink

Part of work for https://codedotorg.atlassian.net/browse/PLAT-339

@dmcavoy dmcavoy requested review from tess323 and a team April 20, 2021 00:32
@tess323
Copy link

tess323 commented Apr 20, 2021

works for me. Thank you for this

@dmcavoy dmcavoy merged commit 99c6671 into staging Apr 20, 2021
@dmcavoy dmcavoy deleted the teacher-instrumentation-5 branch April 20, 2021 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants