Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow exporting large files to PDF #40085

Merged
merged 4 commits into from
Apr 15, 2021
Merged

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Apr 14, 2021

The export_as_file method failes for some of our resources with the following error:

{
  "error": {
    "errors": [
    {
      "domain": "global",
        "reason": "exportSizeLimitExceeded",
        "message": "This file is too large to be exported."
    }
    ],
    "code": 403,
    "message": "This file is too large to be
      exported."
  }
}

For some reason, however, hitting the export URI directly works just fine (this is the method that CB uses). So, let's just do that.

Also skip serializing forms to pdf; that doesn't work at all.

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

The `export_as_file` method failes for some of our resources with the following error:

```json
{
  "error": {
    "errors": [
    {
      "domain": "global",
        "reason": "exportSizeLimitExceeded",
        "message": "This file is too large to be exported."
    }
    ],
    "code": 403,
    "message": "This file is too large to be
      exported."
  }
}
```

For some reason, however, hitting the export URI directly works just fine (this is the method that CB uses). So, let's just do that.

Also skip serializing forms to pdf.
@Hamms Hamms requested a review from a team April 14, 2021 20:52
@Hamms Hamms merged commit 307cff9 into staging Apr 15, 2021
@Hamms Hamms deleted the allow-downloading-large-pdfs branch April 15, 2021 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants