New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to fix the PDF generation crash issue #40099

Merged

Hamms merged 1 commit into staging from address-puppeteer-crash

Apr 16, 2021

Contributor

Hamms commented Apr 15, 2021

This is mostly a speculative fix; the error messages we've been getting aren't super clear. So I'm doing two things in this PR:

Add a flag which I think will fix the crash
Add a flag which will give us better feedback in case I'm wrong about 1

PR Checklist:

Tests provide adequate coverage
Privacy and Security impacts have been assessed
Code is well-commented
New features are translatable or updates will not break translations
Relevant documentation has been added or updated
User impact is well-understood and desirable
Pull Request is labeled appropriately
Follow-up work items (including potential tech debt) are tracked and linked


          Attempt to fix the PDF generation crash issue

bcf3f5d

Hamms requested a review from a team

April 15, 2021 18:24

davidsbailey approved these changes

View reviewed changes

Member

davidsbailey left a comment

this strategy sounds good to me!

Hamms merged commit a48f208 into staging

Hamms deleted the address-puppeteer-crash branch

April 16, 2021 16:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment