Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Maker Lab Redux Error #40120

Merged
merged 2 commits into from
Apr 16, 2021
Merged

Fix Maker Lab Redux Error #40120

merged 2 commits into from
Apr 16, 2021

Conversation

marcd123
Copy link
Contributor

@marcd123 marcd123 commented Apr 16, 2021

A few children components of the Maker lab have become connected components, and thus need Redux store Provider at the root of the Maker lab app.

Follow-up work

@epeach taking ownership of upping test coverage for this page.

Images

BEFORE:
image

AFTER:
image

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@epeach
Copy link

epeach commented Apr 16, 2021

When I tested this on the Maker App, the /maker/setup page still looks like the "Before" and shows these errors:
Screenshot from 2021-04-16 09-04-39

Copy link

@epeach epeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maker App is still showing errors, see comment for more details.

@marcd123
Copy link
Contributor Author

When I tested this on the Maker App, the /maker/setup page still looks like the "Before" and shows these errors:
Screenshot from 2021-04-16 09-04-39

I wonder if it has to do with your OS type. Are you on MacOS or Windows?

@marcd123
Copy link
Contributor Author

When I tested this on the Maker App, the /maker/setup page still looks like the "Before" and shows these errors:
Screenshot from 2021-04-16 09-04-39

@epeach Followed your advice and only provided redux to maker/setup when being viewed from a non-code.org browser. Issue appears to be resolved

Copy link

@epeach epeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Maker App and Google Chrome on Linux. Working on both, so I think we're good to go! Thanks for getting this all wrapped up! 🎉

@epeach epeach merged commit be5a902 into staging Apr 16, 2021
@epeach epeach deleted the maker-toolkit-provider-fix branch April 16, 2021 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants