New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed linting error #40154

Merged

jmkulwik merged 1 commit into staging from fix-lint-error

Apr 19, 2021

Contributor

jmkulwik commented Apr 19, 2021

Error message:

lib/cdo.rb:122:10: C: Style/ParenthesesAroundCondition: Don't use parentheses around the condition of an if.
      if (rack_env?(:development))

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

Tests provide adequate coverage
Privacy and Security impacts have been assessed
Code is well-commented
New features are translatable or updates will not break translations
Relevant documentation has been added or updated
User impact is well-understood and desirable
Pull Request is labeled appropriately
Follow-up work items (including potential tech debt) are tracked and linked


          Fixed linting error

309e79a

jmkulwik requested a review from breville

April 19, 2021 22:02

breville approved these changes

View reviewed changes

jmkulwik merged commit 96d1d7c into staging

jmkulwik deleted the fix-lint-error branch

April 19, 2021 22:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment