Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group Lesson Navigation Dropdown By Lesson Group #40162

Merged
merged 9 commits into from Apr 21, 2021

Conversation

dmcavoy
Copy link
Contributor

@dmcavoy dmcavoy commented Apr 20, 2021

Change the lesson navigation dropdown to group by lesson group instead of just a set number of lessons in each section.

Screen Shot 2021-04-19 at 9 58 20 PM

Links

https://codedotorg.atlassian.net/browse/PLAT-926

Testing story

Updated unit tests for new behavior

@dmcavoy dmcavoy changed the title Lesson dropdown by group Group Lesson Navigation Dropdown By Lesson Group Apr 20, 2021
@dmcavoy dmcavoy requested a review from a team April 20, 2021 02:02
Copy link
Contributor

@bethanyaconnor bethanyaconnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me. One nit, I wonder if it would be worth setting a min width or something on the dropdown. I find the width change when clicking into different groups a bit jarring. (This already existed but was a bit less noticeable because the group names were longer.)

Screen.Recording.2021-04-20.at.7.44.26.AM.mov

@dmcavoy
Copy link
Contributor Author

dmcavoy commented Apr 21, 2021

Change looks good to me. One nit, I wonder if it would be worth setting a min width or something on the dropdown. I find the width change when clicking into different groups a bit jarring. (This already existed but was a bit less noticeable because the group names were longer.)

Screen.Recording.2021-04-20.at.7.44.26.AM.mov

This is a great point Bethany. In order to get this change in sooner, I'm going to create a follow up task for this.https://codedotorg.atlassian.net/browse/PLAT-992

@dmcavoy dmcavoy merged commit 35c0853 into staging Apr 21, 2021
@dmcavoy dmcavoy deleted the lesson-dropdown-by-group branch April 21, 2021 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants