[AiLab] Use new fields in Model Cards #40166
Conversation
| Possible Values:{' '} | ||
| {!feature.values && ( | ||
| <p style={styles.details}> | ||
| min: {feature.min} max: {feature.max} |
There was a problem hiding this comment.
Is this our preferred presentation for ranges across the whole experience? Or should we try and figure out a unified design?
There was a problem hiding this comment.
There are three places where we expose max and min to the user:
Test model in AI Lab
App Lab auto gen design element
App Lab model card (this PR)
The only difference is whether we use ( ) or not, which seems to me to make sense in the above contexts. If you have ideas for an improvement on how to display this information, we can consider it, but in terms of consistency I think the change I've made in this PR for model cards matches the others - single line, min first, then max with colons.
There was a problem hiding this comment.
Seems fair. My only thought is that we could put a comma between them in the third variant...
Continuation of the work in #40100. Rather than
metadata.labelColumnwe now usemetadata.labeland instead ofmetadata.selectedFeatureswe pull info frommetadata.featuresfor theModelCardcomponent.If the model is too old to have these new data fields, the model card doesn't render:
For models that do have the new fields, we now show more details about the label and features in the Model Card, including possible values and max/min where appropriate:
The Curriculum team has been notified of this change; they have re-built all of the necessary models in the curriculum pilot to include the new fields.