Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update several more code blocks in curriculum content with new formatting #40171

Merged
merged 1 commit into from Apr 20, 2021

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Apr 20, 2021

Pass 3: The Stuff We Missed

Follow-up to #39839

Turns out, the scoping regex I was using - text.gsub(/(?<!\[)`[^`]*`/) - is insufficient. In particular, it's too greedy: it was matching against whole paragraphs, and skipping over any relevant content that might be inside those paragraphs. I updated it to actually use the block regex directly: text.gsub(/(?<!\[)#{BLOCK_RE}/) and it found a bunch of things that it had been missing before.

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@Hamms Hamms requested a review from a team April 20, 2021 17:48
Copy link
Contributor

@dmcavoy dmcavoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this!

@Hamms Hamms merged commit 8d770ca into staging Apr 20, 2021
@Hamms Hamms deleted the update-more-curriculum-blocks branch April 20, 2021 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants