Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "revert navbar fix" #40173

Merged
merged 1 commit into from Apr 20, 2021
Merged

Revert "revert navbar fix" #40173

merged 1 commit into from Apr 20, 2021

Conversation

daynew
Copy link
Member

@daynew daynew commented Apr 20, 2021

This reverts commit 58a8a56.

Links

Testing story

  • Verified failing test now passes
bundle exec ruby -Itest ./test/controllers/api_controller_test.rb --name="test_don't_show_link_to_pair_programming_when_not_in_a_section"

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@daynew
Revert "revert navbar fix"
0f7af57 
This reverts commit 58a8a56.
@daynew daynew merged commit ee18ff7 into staging Apr 20, 2021
@daynew daynew deleted the revert-right-to-left-changes branch April 20, 2021 19:03
daynew added a commit that referenced this pull request Apr 21, 2021
@daynew
Revert "Merge pull request #40173 from code-dot-org/revert-right-to-l…
9705fd8 
…eft-changes"

This reverts commit ee18ff7, reversing
changes made to d4cada5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@daynew