Add 'Code Block' button to more markdown editors #40197
Conversation
Specifically, to the lesson Overview, Preparation, and Purpose field editors. Also, the editor for the actitivity secion markdown field is starting to get a _lot_ of buttons; we're going to want to make some changes there (and probably also do something to unify the editor we use for that with the one we use for these fields), so to start playing around with some ideas for what we could do I've collapsed the two-now-three buttons that we had in this editor down to a single dropdown! I think this will work much better, but either way doing this will let us get some early feedback from our editors.
| <a | ||
| className="btn dropdown-toggle" | ||
| data-toggle="dropdown" | ||
| href="#" |
There was a problem hiding this comment.
FYI @madelynkasula that we are using bootstrap + jquery for dropdown functionality here and a few other places. this is probably an interesting case to consider re: component library. Not necessarily blocking for this PR, but you may be best positioned to share out whether it is important for us to avoid bootstrap functionality in react code. My understanding was that react was preferred over bootstrap and/or jquery, but I'm not sure we're very strict about that or whether there are negative implications in this case.
…out the rendering details of the MarkdownEnabledTextarea
|
Just a heads up that MarkdownEnabledTextarea is used in TextareaWithMarkdownPreview which shows on the Course and Script editor as well. It would be good to have follow up tasks to make sure the fields on Course and Script editor which now have this ability support it. |
|
oh, good callout! The functionality in this change is pretty well-contained, but it does look like there are some different stylesheets on those pages which add some undesirable formatting |
I also meant just that if I add a code block or resource in the script or course overview does it work correctly on the script and course overview pages? |
Specifically, to the lesson Overview, Preparation, and Purpose field editors.
Also, the editor for the actitivity secion markdown field is starting to get a lot of buttons; we're going to want to make some changes there (and probably also do something to unify the editor we use for that with the one we use for these fields), so to start playing around with some ideas for what we could do I've collapsed the two-now-three buttons that we had in this editor down to a single dropdown! I think this will work much better, but either way doing this will let us get some early feedback from our editors.
PR Checklist: