Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix javalab button colors in dark mode #40199

Merged
merged 1 commit into from Apr 22, 2021
Merged

Fix javalab button colors in dark mode #40199

merged 1 commit into from Apr 22, 2021

Conversation

JillianK
Copy link
Contributor

I misunderstood how the color.js file works and accidentally removed the background color of the run, settings, stop, and continue buttons in dark mode (making them light grey). This moves those colors I meant to add into color.scss so they'll be generated with the rest of the colors in color.js

Buttons now that I've added back their colors
Screen Shot 2021-04-21 at 2 48 21 PM

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

Copy link
Contributor

@jmkulwik jmkulwik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@JillianK JillianK merged commit 9b300d5 into staging Apr 22, 2021
@JillianK JillianK deleted the jk-fix-colors branch April 22, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants