Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update remaining Resource and Vocab syntaxes to include Course Offering and Version #40216

Merged
merged 2 commits into from
Apr 23, 2021

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Apr 22, 2021

My previous attempt missed several instances; this one should be much more thorough. Rather than trying to do it with a fancy ruby script, I went for good ol' sed:

sed -i 's/\[\(r\|v\) \([a-z0-9\-]*\)\]/\[\1 \2\/coursef\/2021\]/g' coursef-2021.script_json;
sed -i 's/\[\(r\|v\) \([a-z0-9\-]*\)\]/\[\1 \2\/csd\/2021\]/g' csd?-2021.script_json
sed -i 's/\[\(r\|v\) \([a-z0-9\-]*\)\]/\[\1 \2\/csp\/2021\]/g' csp?-2021.script_json

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

…ng and Version

My previous attempt missed several instances; this one should be _much_ more thorough. Rather than trying to do it with a fancy ruby script, I went for sed:

```bash
sed -i 's/\[\(r\|v\) \([a-z0-9\-]*\)\]/\[\1 \2\/coursef\/2021\]/g' coursef-2021.script_json;
sed -i 's/\[\(r\|v\) \([a-z0-9\-]*\)\]/\[\1 \2\/csd\/2021\]/g' csd?-2021.script_json
sed -i 's/\[\(r\|v\) \([a-z0-9\-]*\)\]/\[\1 \2\/csp\/2021\]/g' csp?-2021.script_json
```
@Hamms Hamms requested a review from a team April 22, 2021 18:28
Copy link
Contributor

@dmcavoy dmcavoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Member

@davidsbailey davidsbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! :-)

@Hamms Hamms merged commit 69bcf75 into staging Apr 23, 2021
@Hamms Hamms deleted the update-remaining-vocab-and-resource-syntaxes branch April 23, 2021 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants