Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set width on lesson navigation dropdown so that it doesn't change siz… #40229

Merged
merged 1 commit into from
Apr 23, 2021

Conversation

dmcavoy
Copy link
Contributor

@dmcavoy dmcavoy commented Apr 23, 2021

The lesson navigation dropdown would change size if different sets of lessons in different lesson groups took up different amount of space. This sets a standard size to be used by all the elements so that the component does not change size. I check this on a couple different scripts and it seems to work well for short as well as long names. Sometimes long names are on two lines but I think thats ok.

Copy link
Contributor

@bethanyaconnor bethanyaconnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for following up on this!

@dmcavoy dmcavoy merged commit e398a2e into staging Apr 23, 2021
@dmcavoy dmcavoy deleted the min-width-nav branch April 23, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants