Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make publishing courses easier for editors #40537

Merged
merged 41 commits into from
May 18, 2021
Merged

Make publishing courses easier for editors #40537

merged 41 commits into from
May 18, 2021

Conversation

dmcavoy
Copy link
Contributor

@dmcavoy dmcavoy commented May 12, 2021 •
edited

To simplify the way we publish courses/scripts from the edit pages this PR consolidates a bunch of different fields into one dropdown.

The new HelpTip explains more about the different states:

Screen Shot 2021-05-13 at 10 50 14 PM

Behind the scenes, we are still using visible/hidden, is_stable, and pilot_experiment like before. We want to add more states that something can be in so this will allow us to do that without adding more checkboxes which editors have to keep track of.

Course Edit Publishing

Screen Shot 2021-05-13 at 10 44 59 PM

Script Edit Publishing

Unit in Course

Screen Shot 2021-05-13 at 10 45 13 PM

Standalone Script

Screen Shot 2021-05-13 at 10 46 18 PM

Published Script (not marked Standalone)

Screen Shot 2021-05-13 at 10 46 32 PM

Pilot Script

Screen Shot 2021-05-13 at 10 47 30 PM

Links

https://codedotorg.atlassian.net/browse/PLAT-1050

Follows work done in: #40590

Testing story

  • Lots of tests for the new CourseVersionPublishingEditor
  • Updated tests for ScriptEditor

Follow-up work

  • Added a new state for 'In Development'
  • Adding the ability to have a unit in a course be hidden while the rest of the course is visible

dmcavoy added 14 commits May 11, 2021 22:36
@dmcavoy
Move the published state away from a bunch of checkboxes to one dropdown
becbc77
@dmcavoy
Add dropdown to use on unit when in course
9d722f3
@dmcavoy
Make isStable part of state
2b26d92
@dmcavoy
Make the pilot experiment value update as you change state
3f20499
@dmcavoy
Make updating to assignable or preview work
72b0b8e
@dmcavoy
Make it so a course updates the visible stable and pilot experiment o…
ed6b2e0 
…n its units
@dmcavoy
Remove comment
bb7fbdc
@dmcavoy
Merge branch 'staging' into edit-ui-states
68338f1
@dmcavoy
Clean up CourseVersionPublishedStateSelector
a32b3aa
@dmcavoy
Pull family name and version year out into course version publishing …
2869580 
…state
@dmcavoy
Update the name of the new component
5e27e5f
@dmcavoy
Clean up code a little bit
d80ec1a
@dmcavoy
Update tests for new course version publishing editor
97cdd58
@dmcavoy
Check for the editor showing up in correct situations
53f914f
@dmcavoy dmcavoy changed the title Edit UI states Make publishing courses easier for editors May 13, 2021
davidsbailey
davidsbailey reviewed May 13, 2021
View reviewed changes
Copy link
Member

@davidsbailey davidsbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like a good approach! thanks for checking in. feel free to resolve comments once you've read them.

apps/src/lib/levelbuilder/CourseVersionPublishingEditor.jsx Show resolved Hide resolved
dashboard/app/controllers/courses_controller.rb Outdated Show resolved Hide resolved
apps/src/lib/levelbuilder/script-editor/ScriptEditor.jsx Outdated Show resolved Hide resolved
dashboard/app/controllers/courses_controller.rb Outdated Show resolved Hide resolved
@dmcavoy dmcavoy changed the base branch from staging to move-publishing-units-in-course May 14, 2021 02:29
@dmcavoy dmcavoy changed the base branch from move-publishing-units-in-course to staging May 14, 2021 02:32
@dmcavoy dmcavoy requested a review from a team May 14, 2021 12:27
Base automatically changed from move-publishing-units-in-course to staging May 14, 2021 18:40
@dmcavoy
Copy link
Contributor Author

dmcavoy commented May 14, 2021

Hold on review. Working on updating the course edit page to use the save bar #40607

@dmcavoy dmcavoy changed the base branch from staging to course-save-update May 15, 2021 19:49
@dmcavoy dmcavoy mentioned this pull request May 17, 2021
Merged
@dmcavoy dmcavoy requested a review from a team May 17, 2021 14:27
bethanyaconnor
bethanyaconnor approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@bethanyaconnor bethanyaconnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this PR is time sensitive so I don't want to hold it up. LGTM after addressing the issue with the pilot experiment input.

@dmcavoy dmcavoy changed the base branch from course-save-update to staging May 18, 2021 01:02
@dmcavoy dmcavoy merged commit dd97a32 into staging May 18, 2021
@dmcavoy dmcavoy deleted the edit-ui-states branch May 18, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsbailey davidsbailey davidsbailey left review comments

@bethanyaconnor bethanyaconnor bethanyaconnor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dmcavoy @davidsbailey @bethanyaconnor