Additional foorm survey validation on names #40557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is very cool! |
tim-dot-org
commented
May 12, 2021
bencodeorg
reviewed
May 13, 2021
bencodeorg
reviewed
May 14, 2021
| nameEntries.forEach(match => { | ||
|
|
||
| let match; | ||
| while ((match = nameKeyRegex.exec(text)) !== null) { |
There was a problem hiding this comment.
For my understanding, why a while loop here?
There was a problem hiding this comment.
exec stores some state about where it last found a match, and each time you call it, it finds the next match in the string. when it doesn't find any more matches, it'll return null, and we break out of the loop
There was a problem hiding this comment.
Ooh got it, and I see a similar example in the docs. Thanks!
bencodeorg
approved these changes
May 14, 2021
These values get turned into keys in the query params that get sent to the server and so we want them to be simple strings
tim-dot-org
force-pushed
the
survey-validation
branch
from
31ab7ea
to
5eae6e2
Compare
|
just a rebase on staging to re-trigger tests |
tim-dot-org
force-pushed
the
survey-validation
branch
from
82bbc52
to
7c640fd
Compare
|
the fix i showed you when i was screensharing turned out to actually work, I must have had the saucelabs stuff set up weird |
bencodeorg
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some additional linting validation to the foorm form json editor to prevent "name" and "value" keys from having values outside of alphanumeric and underscores. This stems from an issue where the keys have extra characters stripped away when uploaded to the server.
Functionally, this change hooks into the getAnnotations step of the codeMirror linter, runs the default lint step, and adds additional error messages when needed.
see: code mirror docs
Links
Testing story
Added some unit tests, and tested manually on localhost.