Javalab: add serialized_maze property #40603
Conversation
| end | ||
| return if serialized_maze.nil? | ||
| # convert maze into json object and validate each cell has a tileType | ||
| maze_json = serialized_maze.is_a?(Array) ? serialized_maze.to_json : serialized_maze |
There was a problem hiding this comment.
Is there any reason (or could there be in the future) the serialized_maze wouldn't be of type Array or already in JSON?
There was a problem hiding this comment.
Looking at how it's defined for other levels, it's generally a string which we need to call JSON.parse on. I copied this behavior from how maze parses serialized_maze. I think the only way it would ever be defined as an array is if an engineeer was editing a level manually. Both are parseable (array or escaped string), so seems reasonable to allow both unless we have strong opinions otherwise.
There was a problem hiding this comment.
Gotcha- thanks for the context. That makes more sense. I was wondering if there would be any other formats to worry about, but it sounds like it's a pattern that's been working for maze already!
|
@hannahbergam good call out on testing. I will add a |
For neighborhood levels in Javalab we need to specify a
serialized_mazeproperty, which defines the map for a neighborhood level. This property will be required for any Javalab level withcsa_view_mode='neighborhood'. The expected format is a 2d array of objects, where each object must have atileType(number Maze recongizes as wall, obstacle, open, etc.) and may optionally have anassetIdand/orvalue.Testing story
Tested locally using in-progress work on the Maze repo that renders neighborhood levels.
Follow-up work
We will need to add a new route on levles so that Javabuilder can access the maze as well, as it needs to know the grid setup in order to build the environment for neighborhood on the backend.
PR Checklist: