-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Google Blockly][Outbreak] Set up Outbreak level to work with Google Blockly #40613
Conversation
// TODO | ||
openEditorForFunction(procedureBlock, functionName) {} | ||
|
||
// TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what works for your workflow, but do you have a task or reminder for at the 'end' of getting Outbreak onto Blockly to go back and make sure that all the 'ToDos' are addressed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not all of these TODOs need to be addressed before HOC. In fact, I think most of them will not be addressed as part of Outbreak work. The stubs will need to be filled in when we migrate all of Sprite Lab, but leaving them as no-op stubs for now is fine because Outbreak doesn't actually use the features
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would argue that we should add additional details to the ToDos then - to indicate the lifespan on the ToDo and differentiate between ToDos that require action and expected for-the-time-being No-Op functions .
Is there a technical doc that outlines our approach/philosophy/process to moving things onto Blockly? It might be useful to have just one or two pages that outlines the process and major steps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
These are probably a good place to start: |
Immediately after leaving that comment, I read the Blockly Status doc and was like, "Oh, well, there it is!". 😆 |
Most of the changes here are just adding stubs so that Outbreak, which is a Sprite Lab level, can load without error.
FunctionEditor
- this is the modal function editor which is custom to our fork. Outbreak levels won't actually use this feature.Block.createProcedureDefinitionBlock
- Outbreak won't use procedure blocksdispatchEvent
- used in Sprite Lab when you switch from the costume tab to the code tab. Outbreak levels won't use the costume tab.DEFINITION_BLOCK_TYPES
andBlockValueType
prefixLines
- Our code expects this function to be defined onBlockly.Generator
but in Google Blockly it's onBlockly.JavaScript
, so just aliasing it solves the problem.There's a couple small pure refactor changes in here as well:
googleBlocklyWrapper
tocdoConstants
initializeBlocklyXml
toinitializeTouch
inCdoTouch
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: