Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpret Neighborhood commands from javabuilder #40616

Merged
merged 1 commit into from
May 17, 2021

Conversation

jmkulwik
Copy link
Contributor

@jmkulwik jmkulwik commented May 17, 2021

This pairs with a PR from the javabuilder repo: code-dot-org/javabuilder#36

With this PR, a student can signal that a painter should move.

PainterMove

Task: https://codedotorg.atlassian.net/browse/CSA-293
Neighborhood Doc: https://docs.google.com/document/d/1SqSLogXsOKJD8QexbZAbxCpUGRdNP9Yj7zW8tN6oADI/edit#

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

Copy link
Contributor

@molly-moen molly-moen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay!

@jmkulwik jmkulwik merged commit fb352c3 into staging May 17, 2021
@jmkulwik jmkulwik deleted the integrate-neighborhood branch May 17, 2021 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants