add painter spritesheets to neighborhood assets #40622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
molly-moen
reviewed
May 17, 2021
There was a problem hiding this comment.
Sorry for additional request here, but can you update neighborhoodSprites.json to include the 4 directional painters (asset ids 287-290) and which sheet/row/column they are in? Had a discussion with curriculum this morning and sounds like they want to place placholder painters like other assets, so this will cover our bases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the pattern of the angry birds move_avatar and idle_avatar, I made the spritesheets for the painter using the same scripts I added in this PR, specifically the single sheet one
Painter:
Birds:
Links
PR Checklist: