Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links on educate pages to new urls #40645

Merged
merged 8 commits into from May 21, 2021
Merged

Conversation

dmcavoy
Copy link
Contributor

@dmcavoy dmcavoy commented May 18, 2021

Updates any pegasus page that was still using the old URL pattern to the new /lessons/x/levels/ pattern. I used ruby find and replace on anything in the pegasus directory.

Foundations is it ok to update the translated pages?

@dmcavoy dmcavoy requested a review from a team as a code owner May 18, 2021 03:52
@dmcavoy dmcavoy requested review from daynew, a team and hacodeorg May 18, 2021 13:59
@@ -1,130 +1,130 @@
id_s!,mainConcept_s*,name_t,age_s,lessonURL_t,lessonPlan_t,lessonVid_t,teacherVid_t,sampleTeachingVid_t,objectives_t,overview_t,additional_t,split_s,part1_s,part2_s,courseNum_s,part3_s,lessonNum_s,part4_s,part5_s,courseLesson_s,answers_t,online_t,ema_t
diceRace,Algorithms,Dice Race,9+,https://studio.code.org/s/coursee/stage/10/puzzle/1,https://curriculum.code.org/csf/coursee/10/,https://youtu.be/xaW3PAzHxCU,https://youtu.be/xaW3PAzHxCU,," - Decompose large activities into a series of smaller events.
diceRace,Algorithms,Dice Race,9+,https://studio.code.org/s/coursee/lessons/10/levels/1,https://curriculum.code.org/csf/coursee/10/,https://youtu.be/xaW3PAzHxCU,https://youtu.be/xaW3PAzHxCU,," - Decompose large activities into a series of smaller events.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember if the pegasus gsheets have a two-way sync or not, so it's possible these changes would be overwritten on staging

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimming the code, it doesn't look like we sync back to drive. I think the safest option here is to remove the .csv files from this PR so you can merge it then we can decide if/how to update those CSVs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just went into the google sheets and did find and replace there. So I will remove them from this PR and they will get updated when they get scooped.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! You have much more patience than I do :)

Copy link
Contributor

@Hamms Hamms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updates to translated files in this PR should be removed. Crowdin is the source of truth for our translations, and that's where we should be making updates

@dmcavoy
Copy link
Contributor Author

dmcavoy commented May 18, 2021

The updates to translated files in this PR should be removed. Crowdin is the source of truth for our translations, and that's where we should be making updates

Ok great will do!

@dmcavoy
Copy link
Contributor Author

dmcavoy commented May 18, 2021

All translation files removed. Anyone know the answer on the csv question bethany shared?

@dmcavoy dmcavoy merged commit fd409c4 into staging May 21, 2021
@dmcavoy dmcavoy deleted the educate-pages-links branch May 21, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants