Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stage to lesson in .feature files #40693

Merged
merged 9 commits into from May 21, 2021
Merged

Stage to lesson in .feature files #40693

merged 9 commits into from May 21, 2021

Conversation

dmcavoy
Copy link
Contributor

@dmcavoy dmcavoy commented May 20, 2021 •
edited

Update stage to lesson in UI tests.

https://codedotorg.atlassian.net/browse/PLAT-981

@dmcavoy dmcavoy requested a review from a team May 21, 2021 01:49
@dmcavoy dmcavoy changed the title Stage to lesson feature files Stage to lesson in .feature files May 21, 2021
bethanyaconnor
bethanyaconnor approved these changes May 21, 2021
View reviewed changes
Copy link
Contributor

@bethanyaconnor bethanyaconnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good. Do you know if there are going to be any issues with renaming the test file? Will the eyes test baselines need to be set?

@dmcavoy
Copy link
Contributor Author

dmcavoy commented May 21, 2021

Change looks good. Do you know if there are going to be any issues with renaming the test file? Will the eyes test baselines need to be set?

Looks like Suresh thinks its fine to rename the file: https://codedotorg.slack.com/archives/C0T0PNTM3/p1621615829108700

@dmcavoy dmcavoy merged commit 9115919 into staging May 21, 2021
@dmcavoy dmcavoy deleted the stage-to-lesson-feature-files branch May 21, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bethanyaconnor bethanyaconnor bethanyaconnor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dmcavoy @bethanyaconnor