Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing Foorm processing cronjob #40719

Merged
merged 2 commits into from
May 24, 2021
Merged

Fix failing Foorm processing cronjob #40719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6397fd6
Fix Foorm processing cron entry
bencodeorg May 24, 2021
21bd86c
Handle Forms with no pages and pages with no elements
bencodeorg May 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion cookbooks/cdo-apps/templates/default/crontab.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
cronjob at:'*/3 * * * *', do:dashboard_dir('bin', 'process_pd_workshop_ends')
cronjob at:'*/5 * * * *', do:dashboard_dir('bin', 'fill_jotform_placeholders')
cronjob at:'*/30 * * * *', do:dashboard_dir('bin', 'sync_jotforms')
cronjob at:'0 6 * * *', do:dashboard_dir('bin', 'process_foorm_data')
cronjob at:'0 6 * * *', do:deploy_dir('bin', 'cron', 'process_foorm_data')
cronjob at:'25 7 * * *', do:deploy_dir('bin', 'cron', 'update_hoc_map')
cronjob at:'49 5 * * *', do:deploy_dir('bin', 'cron', 'update_census_mapbox')
cronjob at:'0 9 * * 1-5', do:deploy_dir('bin', 'cron', 'check_for_census_inaccuracy_reports')
Expand Down
4 changes: 2 additions & 2 deletions dashboard/lib/pd/foorm/foorm_parser.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ def self.parse_form_questions(form_questions)

filled_in_form_questions = ::Foorm::Form.fill_in_library_items(form_questions_parsed_from_json)
filled_in_form_questions.deep_symbolize_keys!
filled_in_form_questions[:pages].each do |page|
page[:elements].each do |question_data|
filled_in_form_questions[:pages]&.each do |page|
page[:elements]&.each do |question_data|
parsed_form_questions.deep_merge!(parse_element(question_data, false))
end
end
Expand Down