Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foorm easy versioning UI #40734

Merged
merged 13 commits into from
Jun 2, 2021
Merged

Foorm easy versioning UI #40734

merged 13 commits into from
Jun 2, 2021

Conversation

tim-dot-org
Copy link
Contributor

@tim-dot-org tim-dot-org commented May 24, 2021

Adds a new button "Save as New Version" to published foorm forms which will increment the version of the currently edited form. Also sorts and filters the list of forms to choose from, and allows you to toggle viewing all versions or just the latest version.

filtered-surveys
unfiltered-surveys

Links

Testing story

Added unit tests, tested locally

@tim-dot-org tim-dot-org requested a review from a team May 24, 2021 21:12
@tim-dot-org
Copy link
Contributor Author

rebased on staging, last two commits are new

Copy link
Contributor

@bencodeorg bencodeorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Contributor

@bencodeorg bencodeorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small comments but tests look great and happy to have the warning dialog!

@bencodeorg bencodeorg self-requested a review June 1, 2021 23:37
Copy link
Contributor

@bencodeorg bencodeorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New changes look good to me!

@tim-dot-org tim-dot-org merged commit 426d20f into staging Jun 2, 2021
@tim-dot-org tim-dot-org deleted the foorm-versioning-ui branch June 2, 2021 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants