-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Foorm easy versioning UI #40734
Foorm easy versioning UI #40734
Conversation
apps/src/code-studio/pd/foorm/editor/components/FoormEntityLoadButtons.jsx
Outdated
Show resolved
Hide resolved
apps/src/code-studio/pd/foorm/editor/components/FoormEntityLoadButtons.jsx
Outdated
Show resolved
Hide resolved
apps/src/code-studio/pd/foorm/editor/components/FoormEntityLoadButtons.jsx
Outdated
Show resolved
Hide resolved
apps/src/code-studio/pd/foorm/editor/components/FoormEntityLoadButtons.jsx
Outdated
Show resolved
Hide resolved
apps/test/unit/code-studio/pd/foorm/FoormEntityEditorFormModeTest.js
Outdated
Show resolved
Hide resolved
…e new versions of them yet.
a1f0a54
to
3e0e381
Compare
rebased on staging, last two commits are new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of small comments but tests look great and happy to have the warning dialog!
apps/test/unit/code-studio/pd/foorm/FoormEntityLoadButtonsTest.js
Outdated
Show resolved
Hide resolved
apps/src/code-studio/pd/foorm/editor/components/FoormEntityLoadButtons.jsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New changes look good to me!
Adds a new button "Save as New Version" to published foorm forms which will increment the version of the currently edited form. Also sorts and filters the list of forms to choose from, and allows you to toggle viewing all versions or just the latest version.
Links
Testing story
Added unit tests, tested locally